GitHub Issue 952: Registry containing MVTC import succeeds with error message#7503
Merged
GitHub Issue 952: Registry containing MVTC import succeeds with error message#7503
Conversation
labkey-nicka
approved these changes
Mar 20, 2026
| boolean ret = super.next(); | ||
| if (ret) | ||
| rows.add(((MapDataIterator)_delegate).getMap()); | ||
| rows.add(((MapDataIterator)_delegate).getMapExcludeExistingRecord()); |
Contributor
There was a problem hiding this comment.
How will someone know when they should call getMap() versus getMapExcludeExistingRecord()?
Contributor
Author
There was a problem hiding this comment.
Best I can say is it needs to be evaluated case-by-case. In this case, the map is used to prepare response.rows. Otherwise, getMap with full map should be used while still inside the dataiterator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 952
When update is done using DIB, existingRecord map is included in the response rows object, which shouldn't be.
Related Pull Requests
Changes