Conversation
This was referenced Mar 24, 2026
GitHub Issue 955: limit text choice option length to 200 characters
LabKey/labkey-ui-components#1960
Merged
cnathe
requested changes
Mar 24, 2026
| // Not valid JSON, return null to fall through to default handling | ||
| } | ||
| } | ||
| return null; |
Contributor
There was a problem hiding this comment.
not sure where this comment belongs, but if I go to the LKS grid filter modal for a MVTC field that has values like: "a, b" and "a;b". When I put them both in the filter modal or have multiple lines, it works as expected, but If I just try to include "a;b", it doesn't work. It turns that into an array of "a" and "b"
Contributor
Author
There was a problem hiding this comment.
Could you please file a separate issue for this, unless this is newly introduced? We were not prioritizing LKS scenarios but might want this fixed before the LKS bug bash. This seems the same behavior as regular text field filtering.
Contributor
There was a problem hiding this comment.
new issue added here: https://github.com/LabKey/internal-issues/issues/998
cnathe
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
947: multi value filters on saved view filter panel in LKS is broken
955: limit option length to 200
988: don't allow json array like values for text choice options
Related Pull Requests
Changes