Skip to content

PuppeteerHelper: remove docker mode settings #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-nicka merged 1 commit into from
Mar 26, 2026
Merged

PuppeteerHelper: remove docker mode settings #2924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions src/org/labkey/remoteapi/puppeteer/PuppeteerSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
public class PuppeteerSettings
{
private Boolean _enabled;
private String _mode;
private String _dockerImage;
private Integer _dockerPort;
private String _remoteUrl;

public PuppeteerSettings()
Expand All @@ -36,9 +33,6 @@ public PuppeteerSettings(JSONObject json)
{
this();
_enabled = json.getBoolean("enabled");
_mode = json.getString("mode");
_dockerImage = json.optString("docker.image", null);
_dockerPort = json.optInt("docker.port");
_remoteUrl = json.getString("remote.url");
}

Expand All @@ -57,36 +51,6 @@ public void setEnabled(Boolean enabled)
_enabled = enabled;
}

public String getMode()
{
return _mode;
}

public void setMode(String mode)
{
_mode = mode;
}

public String getDockerImage()
{
return _dockerImage;
}

public void setDockerImage(String dockerImage)
{
_dockerImage = dockerImage;
}

public Integer getDockerPort()
{
return _dockerPort;
}

public void setDockerPort(Integer dockerPort)
{
_dockerPort = dockerPort;
}

public String getRemoteUrl()
{
return _remoteUrl;
Expand All @@ -103,12 +67,6 @@ public JSONObject toJSON()

if (getEnabled() != null)
settings.put("enabled", getEnabled());
if (getMode() != null)
settings.put("mode", getMode());
if (getDockerImage() != null)
settings.put("docker.image", getDockerImage());
if (getDockerPort() != null)
settings.put("docker.port", getDockerPort());
if (getRemoteUrl() != null)
settings.put("remote.url", getRemoteUrl());

Expand Down
1 change: 0 additions & 1 deletion src/org/labkey/test/util/puppeteer/PuppeteerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ public static void enableRemoteService(Connection connection) throws IOException
{
var puppeteerSettings = new PuppeteerSettings();
puppeteerSettings.setEnabled(true);
puppeteerSettings.setMode("remote");
puppeteerSettings.setRemoteUrl(getRemoteServiceURL());

updateSettings(connection, puppeteerSettings);
Expand Down
Loading