Skip to content

lightos nova changes#1

Open
yuval-lb wants to merge 1 commit intostable/wallabyfrom
lightos/wallaby
Open

lightos nova changes#1
yuval-lb wants to merge 1 commit intostable/wallabyfrom
lightos/wallaby

Conversation

@yuval-lb
Copy link
Copy Markdown
Collaborator

This PR is not meant to be merged but just to give a view about what are the changes need to backport the driver to wallaby version.

TBD - extra existing patches should be added. this is just basic driver without further changes like volume states or minor fixes that were added later on.

@muliby-lb
Copy link
Copy Markdown

@yuval-lb the way I would normally do such a change is to add the current yoga upsteream driver, unmodified, and then in follow-on patches make the changes needed to make it work for Wallaby. THis way the review can concentrate on the changes, and not the entire driver. I'ts not a huge deal since this is a pretty small driver, but that's the correct way to do it IMHO.

@@ -0,0 +1,81 @@
# Licensed under the Apache License, Version 2.0 (the "License"); you may
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing copyright statement


class LibvirtLightOSVolumeDriver(libvirt_volume.LibvirtVolumeDriver):
"""Driver to attach NVMe volumes to libvirt."""
VERSION = '2.3.12'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?



class LibvirtLightOSVolumeDriver(libvirt_volume.LibvirtVolumeDriver):
"""Driver to attach NVMe volumes to libvirt."""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs updating

@yuval-lb
Copy link
Copy Markdown
Collaborator Author

@yuval-lb the way I would normally do such a change is to add the current yoga upsteream driver, unmodified, and then in follow-on patches make the changes needed to make it work for Wallaby. THis way the review can concentrate on the changes, and not the entire driver. I'ts not a huge deal since this is a pretty small driver, but that's the correct way to do it IMHO.

There are no changes - its the just the commit from yoga.
The only real change happened in os-brick where I added another commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants