You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is not meant to be merged but just to give a view about what are the changes need to backport the driver to wallaby version.
TBD - extra existing patches should be added. this is just basic driver without further changes like volume states or minor fixes that were added later on.
@yuval-lb the way I would normally do such a change is to add the current yoga upsteream driver, unmodified, and then in follow-on patches make the changes needed to make it work for Wallaby. THis way the review can concentrate on the changes, and not the entire driver. I'ts not a huge deal since this is a pretty small driver, but that's the correct way to do it IMHO.
@yuval-lb the way I would normally do such a change is to add the current yoga upsteream driver, unmodified, and then in follow-on patches make the changes needed to make it work for Wallaby. THis way the review can concentrate on the changes, and not the entire driver. I'ts not a huge deal since this is a pretty small driver, but that's the correct way to do it IMHO.
There are no changes - its the just the commit from yoga.
The only real change happened in os-brick where I added another commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not meant to be merged but just to give a view about what are the changes need to backport the driver to wallaby version.
TBD - extra existing patches should be added. this is just basic driver without further changes like volume states or minor fixes that were added later on.