Add missing arb.sql to postgres-make-concepts.sql#1976
Open
marcofanti wants to merge 1 commit intoMIT-LCP:mainfrom
Open
Add missing arb.sql to postgres-make-concepts.sql#1976marcofanti wants to merge 1 commit intoMIT-LCP:mainfrom
marcofanti wants to merge 1 commit intoMIT-LCP:mainfrom
Conversation
medication/arb.sql exists in the medication/ directory but was not included in postgres-make-concepts.sql, so mimiciv_derived.arb was never created when running the standard concepts build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
medication/arb.sqlexists in themimic-iv/concepts_postgres/medication/directory but is not referenced inpostgres-make-concepts.sql. As a result,mimiciv_derived.arbis never created when running the standard concepts build.Fix
Add
\i medication/arb.sqlafter\i medication/antibiotic.sqlin the medication section ofpostgres-make-concepts.sql(one line, alphabetical order).Steps to reproduce
Run
postgres-make-concepts.sqland then: