fix(#149): replace hardcoded patch count with dynamic positional embedding in CNNT#199
Open
vignathi123-vi wants to merge 2 commits intoML4SCI:mainfrom
Open
Conversation
…l embedding in CNNT
…n CNNT forward pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149
The CNNT model hardcoded num_patches = 16 * 16 in init, causing
shape mismatch errors for variable input resolutions.
Changes made:
Replaced hardcoded num_patches with max_patches = 256
Added dynamic slicing in forward() for inputs smaller than max_patches
Added interpolation in forward() for inputs larger than max_patches
This makes CNNT truly resolution-agnostic across all DeepLense datasets
and input sizes. Happy to make adjustments if needed!