fix(#143): Replace hardcoded absolute paths with argparse + YAML config#202
Open
vignathi123-vi wants to merge 1 commit intoML4SCI:mainfrom
Open
fix(#143): Replace hardcoded absolute paths with argparse + YAML config#202vignathi123-vi wants to merge 1 commit intoML4SCI:mainfrom
vignathi123-vi wants to merge 1 commit intoML4SCI:mainfrom
Conversation
…in BYOL/inference scripts
|
happy to make further improvements based on feedback |
|
Added support for configurable paths using argparse and optional YAML config. |
Author
|
Thanks for your contribution @likitha487. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143
Problem
Three scripts had hardcoded absolute paths pointing to the original developer's
machine, making them completely non-functional for anyone else.
Files Changed
inference.py— replaced hardcodedlog_dirandfinetune_model_pathfinetune_byol.py— replaced hardcodedsaved_model_pathfinetune.py— replaced hardcodedsaved_model_pathWhat this PR adds beyond existing PRs (#144, #169)
YAML config files for all 3 scripts inside
config/yaml/as suggested by mentors--configflag to point to any custom config filePath validation with clear
FileNotFoundErrormessages so users know exactly what is missingCLI args override YAML values so both workflows are supported
num_workers,split_ratio,dataset_namealso moved to configUsage after fix