fix(display): use dash in Temp/Hum page#186
Open
jkoelker wants to merge 1 commit intoMallocArray:mainfrom
Open
fix(display): use dash in Temp/Hum page#186jkoelker wants to merge 1 commit intoMallocArray:mainfrom
jkoelker wants to merge 1 commit intoMallocArray:mainfrom
Conversation
Owner
|
Thoughts on just using a - instead of a slash entirely? Using a different character that looks like a regular slash seems like it will cause confusion down the road, vs possibly just using dash instead. |
Author
|
Yea that works, as the initial go i just did the least visual change thing possible in line with esphome's directive, but I agree that a '-' is probably a better choice. |
jkoelker
changed the title
ESPHome reserves '/' for URL path separators and warns that this name will become an error in 2026.7.0. ESPHome recommends the "Unicode Fraction Slash"; however, this may cause confusion as it is visually similar. Use a '-' instead to reduce potential confusion. Fixes: MallocArray#183
Author
|
Sorry for the two pushes, noticed I had spelling mistakes when editing the pr in github 🤣. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESPHome reserves '/' for URL path separators and warns that this
name will become an error in 2026.7.0.
ESPHome recommends the "Unicode Fraction Slash"; however, this may
cause confusion as it is visually similar. Use a '-' instead to
reduce potential confusion.
Fixes: #183