Removed the hold and tap behavior of the filtering map button#4456
Open
gabriel-bolbotina wants to merge 3 commits intodev/filteringfrom
Open
Removed the hold and tap behavior of the filtering map button#4456gabriel-bolbotina wants to merge 3 commits intodev/filteringfrom
gabriel-bolbotina wants to merge 3 commits intodev/filteringfrom
Conversation
gabriel-bolbotina
added
enhancement
map tools
Coverage Report for CI Build 24514386312Warning No base build found for commit Coverage: 58.411%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
gabriel-bolbotina
force-pushed
the
filter-modify-filter-chip
branch
from
ff9e39c to
0837669
Compare
📦 Build Artifacts Ready
|
Changed the bahviour of the floating button
📦 Build Artifacts Ready
|
Withalion
reviewed
Apr 18, 2026
📦 Build Artifacts Ready
|
Withalion
reviewed
Apr 20, 2026
| emit hasFiltersAvailableChanged(); | ||
|
|
||
| //return early if filtering is not setup | ||
| if ( !valueRead ) |
Contributor
There was a problem hiding this comment.
My mistake but this should probably be:
Suggested change
| if ( !valueRead ) | |
| if ( !filteringAvailable ) |
as we can successfully read false value too and it doesn't really make sense to go through the rest
Comment on lines
+346
to
+355
| bool anyActivated = false; | ||
| for ( const QVariant &value : std::as_const( newFilters ) ) | ||
| { | ||
| if ( value.isValid() && !value.isNull() ) | ||
| { | ||
| anyActivated = true; | ||
| break; | ||
| } | ||
| } | ||
| setFiltersActivated( anyActivated ); |
Contributor
There was a problem hiding this comment.
I meant to do this:
Suggested change
| bool anyActivated = false; | |
| for ( const QVariant &value : std::as_const( newFilters ) ) | |
| { | |
| if ( value.isValid() && !value.isNull() ) | |
| { | |
| anyActivated = true; | |
| break; | |
| } | |
| } | |
| setFiltersActivated( anyActivated ); | |
| setFiltersActivated( !newFilters.isEmpty ); |
The inputs should be responsible to give you valid value back and they should not return null values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the filters enabled member variable to filters activated.
Changed the behaviour of the filter floating button as discussed in this issue
UI:
Enregistrement.de.l.ecran.2026-04-17.a.12.05.30.mov