Skip to content

feat: add NOYA token metadata#1753

Open
HasanHajHasan wants to merge 1 commit intoMetaMask:masterfrom
HasanHajHasan:noya-token-metadata
Open

feat: add NOYA token metadata#1753
HasanHajHasan wants to merge 1 commit intoMetaMask:masterfrom
HasanHajHasan:noya-token-metadata

Conversation

@HasanHajHasan
Copy link

@HasanHajHasan HasanHajHasan commented Mar 12, 2026

Note

Low Risk
Adds a new ERC-20 metadata entry and SVG asset only; no code or runtime logic changes.

Overview
Adds metadata for the Base (chain 8453) ERC-20 token NOYA (Noya Network, 18 decimals) via a new metadata/eip155:8453/erc20:0x0ae2...4014.json entry.

Includes a new corresponding token logo SVG at icons/eip155:8453/erc20:0x0ae2...4014.svg and links it from the metadata.

Written by Cursor Bugbot for commit 38efa49. This will update automatically on new commits. Configure here.

@HasanHajHasan HasanHajHasan requested review from a team and MRabenda as code owners March 12, 2026 22:11
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

<path class="cls-3" d="M25.1,14.18c-1.63.57-2.38-2-.71-2.39,1.54-.36,2.16,1.89.71,2.39Z"/>
<g class="cls-11">
<g class="cls-12">
<image width="34" height="33" transform="translate(4.66 5.17) scale(.48)" xlink:href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACIAAAAgCAYAAAB3j6rJAAAACXBIWXMAABcRAAAXEQHKJvM/AAAHC0lEQVRYhbWXXaimVRXHf2vt/Z6PcXTGwcEPmkGxxCzJLvRGRASpqBz6ILwRiroIAusiuohu+sLAKEKI6iKoQLoKzCAoCYzMlC6ySUWyaUANvaicceac93mevddaXez9fswZBzNowz57v+/Z59m/57/W+u99JCKCPW04BY/fFzzzQ9jaB9v7he0DwdalsO8wbF8GW5fB5mFh81CQDwr5IpBNIIEDtUCdYLYFV1wPG9t7d1k1EZG898uXnwoe+lTw72eE7Q1II+SNIE9CntrDS4FskCuYC+ptcwkIBw+w2tbOT8Opl+DITXDpkQvD6PqH5x8NvnuH8cKfgmrBVGEqMI2tlxGmBcwUFGvrqgfVoRqYrdSoA5Q5DGfg2V/DK89dGGSpyItPBd/7cKGeEmaAGAiCCmiCtAFpO0hDU0kL6NRGKmAgCdygjh1id60PcPzh9ru3vOsCILungu98dOC100JGAEVCEAukCKKgc5ABdOgAE8gIMkFMECUQEbxCHYKyI0w7UOcNZKHQ8Z/D/sNw8KrXAfnRF0ZeeclISQlXIpwIIBSqgIBMgUygI9ChGNo85uAbICWwqYWjnG0wdd5UsKn3Ar/7Adz1lT0gTz9W+c1PB1JSXIKQwF0Jp8MAJuAtXBSgBjKHGAQ7AzVDdkFz28jmMJ1pytS54IWmVIGoMJyFE7+Ha29dA3nw/h1qdtwbQBtbjwiCILKACPSqYAQfwHeCuiGUBLmAKIQJdRds6H0MvLaQua364z/ZA/LnJ0dkJqgL7oG54OENKhQXhaT4DEJlqZBP4HOoM2EWrbRFIAx8EnwEG2nrahAmuPfyNpgGOPlHuObmDmLZkRDcBY1onuCKR2A4LkIkxTcEkhAhWJUW77lQVJiZkOZCyi2EXiAmIWoDCW+A4Ws94MQTayA+ayAEeDRzkvA2R3BRXBXPQqjgIbgJPgk2CEWEmSkpCykJEtqtFaKHhL45axAEPP8HuPPeBUgKhIAAASIECTCEhOAYri08Ia20ccGL4KOwgVIsSFlJKih0GCFqgAviEB4QTbHFoVJfW8uRSIvS6D+jGRnNo0gIIQEaoAI4boIVwVQoLmx4ImmgqiRARZC1jcVp88VWqy154fjCRzSWAMhClb5KwCIQAZFoeC4tWYvgCBZKtSAlJWsiKSgtrNJfSgKIaCbJmi2shm6kHWLZ1ubtpZxKfzNpXuDRQVzJWZmlRNUgKSSRDpO6T7cHCe1gPGeLWIAsvj3vMrBa2U7WoBJgTkTg3irNkpKrUnMmr4EkFVQUJVDRDhHL7aTPVor8Fy0isGjpHxgujmurHkuKacLMMQ2SBik1kCRKUu2qtNBql6KFLbjiWlkDWSbJnrjQ3BWvhBciKtrcBZPAVBpESpjNqMnJKcjWSjmrYAJJ8zJEIj1v+nxr/0KRRWLGonJiBRDeDkAv7RDxCcHQcFK3C08JTxlLRlbDk2MpmCUwDXICkxYeFWkVRTupb7xt9dI58F5O7VzhHIBKuBE+ETaxOL0Ux6SVqWmipswsbWDJ8BwkCyJDSoF7U6SBKKraElmEd9yWViCXX6m88o9CdMsLt34NMMILboWwibAROpSEtyRUJaVEthmeKrPshAcpBRGQPXANTI2UMkkS6gsg4a3vXoHoJ+49iHslvOI24V5wG7E6x8ocq7vUukutc0o5S53OUsYzlLJLmXYo0y6lDpQ6MJU5U5lT68BUBsYyMNWBUkdKnSi1UK1SvXLz+4VDV65CIxERn/zgCf769A4RtUM1JdwLXkfCRtzGrkxBwhGBpAlNmZy2yHmTpBvkvEnO2+S0SUqb5N6TZpLOUE1cfCDzzV9ewr6LexEvbvFfvP8qPv6+Z3EvTRmfmjo2trEOKxAviFu7FqZMillPbiOyLyuvJfvK1l2dSEGKGcc+vW8JsQwNwNtu2OZL3zqK+4TZiNnQxz73AfNx1ZmwmJafqw1UH6k2UqyFotpEtdVoPlFt4tZjM957z/n/5CwN7QMfO8xzx1/lwe//refKhHeA8BH3kYhCUIFAECKsVZl3U0AQUUwUseYW64Z9zds3+cw3Dp0HsVRk0T7/tev48gPv7BAT1kePglNx2hjLuWFRsShtbRSqT5hNmBdqH80Ld3zkEr79i6tfF2KZrHu/fO4vr3Lv3Y/w4sl/4T4uwSJqu2p1RQQlSUZ11hJVt0hpk6Rb5LxF1k0OHLqIz379Bt5z9+UXhhCR1wUBOHN64pGHT/DAVx/jxZP/7CBGu6VEP7gSKgmVc0Gytoo5ds91fO6+G9l/YHZBiDcEWW8/+/Fxnnj07/zqoWc4fWoH8K6HopJRmaEyI+smd37oem65/Qh33HU1Vx696I0e/eZA1tuzT73Ma6fmADz525PccNNVXHJwH4Jwy+1H38yjzgH5n/7w/9H+AxVT6F6oBItVAAAAAElFTkSuQmCC"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG contains forbidden embedded raster image tag

Medium Severity

The SVG contains an <image> tag with an embedded base64-encoded PNG, which the project's STYLEGUIDE.md explicitly forbids under "Embedded images or nested SVGs": "❌ Do NOT use: <image> tags (PNG/JPEG inside an SVG)." The style guide requires pure vector paths and shapes only. This can cause rendering inconsistencies and defeats the purpose of using SVG.

Fix in Cursor Fix in Web

.cls-14 {
fill: #282828;
}
</style>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG uses forbidden embedded CSS style block

Low Severity

The SVG contains a <style> block with embedded CSS selectors (.cls-1 through .cls-14), which the project's STYLEGUIDE.md explicitly discourages: "❌ Avoid: <style> blocks in SVG" and "Embedded CSS selectors (.cls-1 { fill: red; })." Generic class names like .cls-1 risk conflicts when multiple SVGs are rendered on the same page.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant