GEOPY-2769: optional environment parameter for pixi envs [WIP]#164
Open
GEOPY-2769: optional environment parameter for pixi envs [WIP]#164
Conversation
sebhmg
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable GitHub Actions workflows/actions to better support Pixi environment selection and to make the Pytest invocation configurable.
Changes:
- Add a
pixi-environmentinput to reusable workflows and thread it through to the Pixi setup action. - Add a
test-cmdinput to the reusable Pytest workflow to allow overriding the test command. - Update Pixi setup action reference from
v3.2tov3.4.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/reusable-python-static_analysis.yml | Adds pixi-environment input and passes it into the Pixi setup action; bumps action ref to v3.4. |
| .github/workflows/reusable-python-pytest.yml | Adds test-cmd and pixi-environment inputs; uses TEST_CMD when running tests; bumps Pixi setup action ref to v3.4. |
| .github/actions/reusable-python-setup_pixi/action.yml | Adds an environment input and uses it to select the Pixi env name when provided. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| description: > | ||
| Pixi environment name to install. When provided, takes precedence over | ||
| the name derived from python-version (py<version-without-dots>). | ||
| required: false |
There was a problem hiding this comment.
New input environment is missing a type: field, while other inputs in this composite action declare one (e.g., python-version, cache-number). Add type: string to keep input metadata consistent and avoid schema/validation drift.
Suggested change
| required: false | |
| required: false | |
| type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for testing approach on top of #163