Skip to content

GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names#380

Open
domfournier wants to merge 3 commits intorelease/GA_4.8from
GEOPY-1029B
Open

GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names#380
domfournier wants to merge 3 commits intorelease/GA_4.8from
GEOPY-1029B

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented Apr 16, 2026

GEOPY-1029 - Add datetime stamp to simpeg.log and simpeg.out file names

Copilot AI review requested due to automatic review settings April 16, 2026 22:56
@github-actions github-actions bot changed the title GEOPY-1029 GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names Apr 16, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes inversion log artifact filenames (e.g., SimPEG.log) to be deterministic across runs, and updates related tests and directive configuration accordingly.

Changes:

  • Switch inversion logger output from timestamped SimPEG_<timestamp>.log to fixed SimPEG.log (and delete any pre-existing file on start).
  • Update ScaleMisfitMultipliers chi-factor output filename to fixed ChiFactors.log.
  • Update gravity driver test expectations to reference the new fixed filenames.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
simpeg_drivers/driver.py Write logs to SimPEG.log (fixed name), return Path from get_path, and remove any existing log at start.
simpeg_drivers/components/factories/directives_factory.py Change chi-factor log output to ChiFactors.log (fixed name).
tests/run_tests/driver_grav_test.py Update test to read SimPEG.log and assert workspace entities for SimPEG.log / SimPEG.out.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpeg_drivers/driver.py
Comment thread simpeg_drivers/components/factories/directives_factory.py
Comment thread tests/run_tests/driver_grav_test.py
Copy link
Copy Markdown
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on simpeg pr, I think we should be warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants