GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names#380
Open
domfournier wants to merge 3 commits intorelease/GA_4.8from
Open
GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names#380domfournier wants to merge 3 commits intorelease/GA_4.8from
domfournier wants to merge 3 commits intorelease/GA_4.8from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes inversion log artifact filenames (e.g., SimPEG.log) to be deterministic across runs, and updates related tests and directive configuration accordingly.
Changes:
- Switch inversion logger output from timestamped
SimPEG_<timestamp>.logto fixedSimPEG.log(and delete any pre-existing file on start). - Update ScaleMisfitMultipliers chi-factor output filename to fixed
ChiFactors.log. - Update gravity driver test expectations to reference the new fixed filenames.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
simpeg_drivers/driver.py |
Write logs to SimPEG.log (fixed name), return Path from get_path, and remove any existing log at start. |
simpeg_drivers/components/factories/directives_factory.py |
Change chi-factor log output to ChiFactors.log (fixed name). |
tests/run_tests/driver_grav_test.py |
Update test to read SimPEG.log and assert workspace entities for SimPEG.log / SimPEG.out. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benk-mira
requested changes
Apr 17, 2026
Contributor
benk-mira
left a comment
There was a problem hiding this comment.
See comment on simpeg pr, I think we should be warning
benk-mira
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-1029 - Add datetime stamp to simpeg.log and simpeg.out file names