Skip to content

⚡ Bolt: Cache favorites to avoid redundant JSON parsing#38

Open
MrAlokTech wants to merge 1 commit intomainfrom
bolt-cache-favorites-7284458044759726191
Open

⚡ Bolt: Cache favorites to avoid redundant JSON parsing#38
MrAlokTech wants to merge 1 commit intomainfrom
bolt-cache-favorites-7284458044759726191

Conversation

@MrAlokTech
Copy link
Owner

💡 What: Added favoritesCache global variable to store the parsed list of favorited PDFs. Updated getFavorites() to return the cache and toggleFavorite() to update it, avoiding redundant calls to localStorage.getItem and JSON.parse during loop rendering.

🎯 Why: During list rendering loops in renderPDFs, the createPDFCard logic frequently called getFavorites(), causing redundant, synchronous execution of localStorage.getItem and JSON.parse. This change moves this check to a lightweight in-memory cache variable, speeding up rendering of large arrays.

📊 Impact: Reduces repetitive synchronous disk reads and JSON parsing overhead from O(N) where N is number of PDF cards shown, to O(1) single parse per user session.

🔬 Measurement: Local tests via python script verify.py validated that the caching variable reliably intercepted standard localStorage requests and smoothly handled toggles.


PR created automatically by Jules for task 7284458044759726191 started by @MrAlokTech

Co-authored-by: MrAlokTech <107493955+MrAlokTech@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages
Copy link

Deploying classnotes with  Cloudflare Pages  Cloudflare Pages

Latest commit: 66dcadd
Status: ✅  Deploy successful!
Preview URL: https://c06019ee.classnotes.pages.dev
Branch Preview URL: https://bolt-cache-favorites-7284458.classnotes.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant