Skip to content

Chore: [AEA-0000] - bump dev container version to 1.4.8#501

Merged
anthony-nhs merged 1 commit intomainfrom
bump_dev_container_1_4_8
Apr 17, 2026
Merged

Chore: [AEA-0000] - bump dev container version to 1.4.8#501
anthony-nhs merged 1 commit intomainfrom
bump_dev_container_1_4_8

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

bump dev container version to 1.4.8

Copilot AI review requested due to automatic review settings April 16, 2026 18:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the development container tooling to version v1.4.8 and updates CI workflows to use the corresponding newer quality-checks-devcontainer reusable workflow revision.

Changes:

  • Update .devcontainer/devcontainer.json to build against devcontainer image version v1.4.8.
  • Bump the quality-checks-devcontainer.yml reusable workflow reference SHA in CI/release/pull request workflows.
  • Adjust zizmor.yml ignore coordinates for unpinned-image findings.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
zizmor.yml Updates zizmor ignore locations for unpinned image findings.
.github/workflows/release.yml Bumps quality-checks-devcontainer reusable workflow SHA.
.github/workflows/pull_request.yml Bumps quality-checks-devcontainer reusable workflow SHA.
.github/workflows/ci.yml Bumps quality-checks-devcontainer reusable workflow SHA.
.devcontainer/devcontainer.json Bumps devcontainer image version from v1.4.4 to v1.4.8.

Comment thread zizmor.yml
Comment on lines +7 to +8
- sam_release_code.yml:55:18
- sam_package_code.yml:15:18
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated zizmor ignore locations (sam_release_code.yml:55:18 and sam_package_code.yml:15:18) don’t appear to match the actual column position of the flagged image: keys (they’re still indented to start around column 7). This will likely cause zizmor to stop ignoring the intended findings and fail CI. Re-run zizmor (or check the SARIF locations) and set the ignore coordinates to the exact reported line/column for those image: entries.

Suggested change
- sam_release_code.yml:55:18
- sam_package_code.yml:15:18
- sam_release_code.yml:55:7
- sam_package_code.yml:15:7

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link
Copy Markdown

@anthony-nhs anthony-nhs merged commit 85ec0ba into main Apr 17, 2026
20 checks passed
@anthony-nhs anthony-nhs deleted the bump_dev_container_1_4_8 branch April 17, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants