Skip to content

Chore: [AEA-0000] - use gitleaks for secret scanning #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Apr 17, 2026
Merged

Chore: [AEA-0000] - use gitleaks for secret scanning #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .gitallowed
View file
Open in desktop

This file was deleted.

19 changes: 10 additions & 9 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ repos:
- id: grype-scan-local
name: Grype scan local changes
entry: make
args: ["grype-scan-local"]
args: [ "grype-scan-local" ]
language: system
pass_filenames: false
always_run: true
Expand All @@ -45,30 +45,31 @@ repos:
pass_filenames: false
always_run: true

- id: git-secrets
name: Git Secrets
description: git-secrets scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
- id: gitleaks
name: Git Leaks
description: gitleaks scans commits, commit messages, and --no-ff merges to
prevent adding secrets into your git repositories.
entry: bash
args:
- -c
- "git-secrets --pre_commit_hook"
- "gitleaks git --pre-commit --redact --staged --verbose"
Comment on lines +50 to +55
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gitleaks hook description looks like it was copied from the previous git-secrets hook (mentions scanning commit messages and --no-ff merges). With the current command (gitleaks ... --staged), it’s describing different behavior, which can confuse contributors. Please update the description to match what this hook actually scans and how it’s intended to be used in this repo.

Copilot uses AI. Check for mistakes.
language: system
Comment on lines +48 to 56
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR switches the local pre-commit secret scan from git-secrets to gitleaks, and also removes the repo’s .gitallowed allowlist. However, the repository still appears to run git-secrets-based scanning in CI (e.g. quality-checks-devcontainer.yml runs git-secrets / make secret-scan). That mismatch makes the change incomplete and could cause CI failures or different secret-scanning results between local and CI (especially now that .gitallowed is gone). Please align CI and local secret scanning to the same tool (migrate CI to gitleaks too, or keep git-secrets/allowlist until CI is updated).

Copilot uses AI. Check for mistakes.

- id: lint-githubactions
name: Lint github actions
entry: make
args: ["lint-githubactions"]
args: [ "lint-githubactions" ]
language: system
files: ^.github
types_or: [yaml]
types_or: [ yaml ]
pass_filenames: false

- id: lint-githubaction-scripts
name: Lint github action scripts
entry: make
args: ["lint-githubaction-scripts"]
args: [ "lint-githubaction-scripts" ]
language: system
files: ^.github/scripts
types_or: [sh, shell]
types_or: [ sh, shell ]
pass_filenames: false
fail_fast: true