Skip to content

Chore: [AEA-0000] - use gitleaks for secret scanning #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Apr 17, 2026
Merged

Chore: [AEA-0000] - use gitleaks for secret scanning #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .gitallowed
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ repos:
pass_filenames: false


- id: git-secrets
name: Git Secrets
description: git-secrets scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
- id: gitleaks
name: Git Leaks
description: gitleaks scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hook description appears to be carried over from git-secrets (mentions scanning commit messages and --no-ff merges). Gitleaks’ pre-commit integration generally scans content (e.g., staged changes), not commit messages, so this description is misleading; update it to accurately reflect what this hook actually checks.

Suggested change
description: gitleaks scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
description: gitleaks scans staged changes for secrets before they are committed to the repository.

Copilot uses AI. Check for mistakes.
entry: bash
args:
- -c
- 'git-secrets --pre_commit_hook'
- "gitleaks git --pre-commit --redact --staged --verbose"
language: system
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass_filenames is omitted for this local hook. Since the command already determines what to scan via --staged (and all other local hooks in this file set pass_filenames: false), pre-commit will append a potentially large list of filenames to the bash -c invocation, which can hit OS arg length limits and is unnecessary. Add pass_filenames: false to this hook for consistency and to avoid oversized command lines.

Suggested change
language: system
language: system
pass_filenames: false

Copilot uses AI. Check for mistakes.

fail_fast: true
Expand Down