Chore: [AEA-0000] - bump dev container version to 1.4.8#16
Conversation
There was a problem hiding this comment.
Pull request overview
Updates this repo’s GitHub Actions workflows to use a newer revision of the shared quality-checks-devcontainer reusable workflow from NHSDigital/eps-common-workflows, intended to bump the devcontainer tooling to version 1.4.8.
Changes:
- Bump
quality-checks-devcontainer.ymlreusable workflow reference SHA in CI, PR, and release workflows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updates the quality_checks reusable workflow SHA for release runs. |
| .github/workflows/pull_request.yml | Updates the quality_checks reusable workflow SHA for PR runs. |
| .github/workflows/ci.yml | Updates the quality_checks reusable workflow SHA for main-branch CI runs. |
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@68c2dea999875055ecbfdf055d8391e6e8b8ce2f | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | ||
| needs: [get_config_values] |
There was a problem hiding this comment.
This PR bumps the eps-common-workflows ref for quality-checks-devcontainer, but the tag_release job in this workflow still references the older eps-common-workflows SHA for tag-release-devcontainer.yml. If the goal is to bump the devcontainer version to 1.4.8 across the pipeline, this likely leaves the tagging/release step on the previous devcontainer workflow version; consider updating tag-release-devcontainer.yml@... to the same (or corresponding) SHA as well so both jobs use the intended devcontainer version.
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@68c2dea999875055ecbfdf055d8391e6e8b8ce2f | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | ||
| needs: [get_config_values] | ||
| permissions: |
There was a problem hiding this comment.
This updates quality-checks-devcontainer to a new eps-common-workflows SHA, but tag_release in the same workflow still uses the older tag-release-devcontainer.yml@68c2.... If the intent is to bump the devcontainer version to 1.4.8, consider updating the tag-release-devcontainer reference too so the workflow is consistently using the new devcontainer tooling during tagging.
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@68c2dea999875055ecbfdf055d8391e6e8b8ce2f | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | ||
| needs: [get_config_values] | ||
| permissions: |
There was a problem hiding this comment.
Only the quality-checks-devcontainer reusable workflow SHA was bumped here, but the tag_release job still points at the previous tag-release-devcontainer.yml@68c2.... If the devcontainer version bump to 1.4.8 is meant to apply end-to-end, consider bumping the tag-release-devcontainer SHA as well (or clarify why tagging should remain on the older version).
bump dev container version to 1.4.8