Fix URL handling by preserving trailing slash#102
Open
allrob23 wants to merge 1 commit intoNHSDigital:developfrom
Open
Fix URL handling by preserving trailing slash#102allrob23 wants to merge 1 commit intoNHSDigital:developfrom
allrob23 wants to merge 1 commit intoNHSDigital:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, while reviewing the code as part of an ongoing research project, we came across an issue with how URLs are handled when mounting adapters. The current implementation (Line 372 in
mesh_client/__init__.py)uses:This strips the trailing / from the URL, However, in lines 404–407,
self._urlis passed directly into self._session.mount(...). According to the Requests documentation, full hostnames are recommended to be terminated with a slash. Without the slash, certain requests may not be matched by the intended adapter.We came across this issue while using the project in a research study. Thank you for your time and consideration.