Chore: [AEA-0000] - bump dev container version to 1.4.8#738
Conversation
|
There was a problem hiding this comment.
Pull request overview
Bumps the devcontainer base image version to v1.4.8 and updates GitHub Actions workflows to use a newer revision of the shared devcontainer quality checks workflow.
Changes:
- Update
.devcontainer/devcontainer.jsonto useIMAGE_VERSION: v1.4.8. - Update CI/release/PR workflows to reference a newer
eps-common-workflowscommit forquality-checks-devcontainer.yml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updates the pinned quality-checks-devcontainer.yml reusable workflow ref. |
| .github/workflows/pull_request.yml | Updates the pinned quality-checks-devcontainer.yml reusable workflow ref for PR checks. |
| .github/workflows/ci.yml | Updates the pinned quality-checks-devcontainer.yml reusable workflow ref for main-branch CI. |
| .devcontainer/devcontainer.json | Bumps the devcontainer image version to v1.4.8. |
| verify_published_from_main_image: true | ||
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc |
There was a problem hiding this comment.
This workflow now pins quality-checks-devcontainer.yml to a different eps-common-workflows commit than the other referenced workflows (get-repo-config.yml, tag-release-devcontainer.yml). Mixing refs can cause subtle incompatibilities if inputs/outputs change between commits and makes future upgrades harder to track. Consider updating the other uses: refs to the same commit (or centralising the ref via a reusable workflow/input) so all common workflows are version-aligned.
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 |
|
|
||
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc |
There was a problem hiding this comment.
This workflow now pins quality-checks-devcontainer.yml to a different eps-common-workflows commit than the other referenced workflows in this file. Mixing refs can cause incompatibilities if the reusable workflows’ inputs/outputs evolve independently. Consider bumping the other uses: refs to the same commit (or otherwise keeping them aligned) to reduce maintenance risk.
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 |
|
|
||
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc |
There was a problem hiding this comment.
quality-checks-devcontainer.yml is now pinned to a different eps-common-workflows commit than the other reusable workflows used in this file. Keeping all NHSDigital/eps-common-workflows references aligned to the same commit helps avoid contract mismatches (inputs/outputs) and simplifies upgrades. Consider bumping the remaining refs to the same commit as well.
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 |
|
bump dev container version to 1.4.8