Skip to content

Chore: [AEA-0000] - add ignore scripts option#655

Merged
anthony-nhs merged 1 commit intomainfrom
ignore_scripts
Apr 15, 2026
Merged

Chore: [AEA-0000] - add ignore scripts option#655
anthony-nhs merged 1 commit intomainfrom
ignore_scripts

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change

Details

  • add ignore-script to npm ci

Copilot AI review requested due to automatic review settings April 15, 2026 10:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the project’s Node.js dependency installation step to prevent npm lifecycle scripts from running during make install, aligning with the goal of adding an “ignore scripts” option to npm ci.

Changes:

  • Add --ignore-scripts to the npm ci command in the Makefile.

Comment thread Makefile

install-node:
npm ci
npm ci --ignore-scripts
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci --ignore-scripts will skip lifecycle scripts (e.g., postinstall) that some dependencies rely on to build native modules or generate required artifacts. If those scripts are needed for local development or CI, consider making this behavior configurable (e.g., IGNORE_SCRIPTS ?= 1 and conditionally append --ignore-scripts, or provide a separate target like install-node-no-scripts).

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link
Copy Markdown

@anthony-nhs anthony-nhs merged commit 811f2b4 into main Apr 15, 2026
15 checks passed
@anthony-nhs anthony-nhs deleted the ignore_scripts branch April 15, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants