Remove deprecated cdi.default from ClusterPolicy template#2263
Open
lexfrei wants to merge 1 commit intoNVIDIA:mainfrom
Open
Remove deprecated cdi.default from ClusterPolicy template#2263lexfrei wants to merge 1 commit intoNVIDIA:mainfrom
lexfrei wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The cdi.default field was removed from values.yaml in v26.3.0 when CDI was made the default device injection mechanism (cdi.enabled=true now automatically configures CDI as the default). The conditional block in the ClusterPolicy template was left behind and is now dead code. Signed-off-by: Aleksei Sviridkin <f@lex.la>
lexfrei
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes the dead conditional block for
cdi.defaultfrom the ClusterPolicy Helm template.The
cdi.defaultfield was removed fromvalues.yamlwhen CDI was made the default device injection mechanism in v26.3.0 (cdi.enabled=truenow automatically configures CDI as the default). The conditional block in the template was left behind:Since
cdi.defaultno longer exists invalues.yaml, this block never renders and is dead code.