Run toolkit validation in operand init containers#2264
Draft
rajathagasthya wants to merge 1 commit intomainfrom
Draft
Run toolkit validation in operand init containers#2264rajathagasthya wants to merge 1 commit intomainfrom
rajathagasthya wants to merge 1 commit intomainfrom
Conversation
rajathagasthya
force-pushed
the
fix/init-container-nvidia-module-check
branch
2 times, most recently
from
b578788 to
ce2ef9a
Compare
rajathagasthya
changed the title
rajathagasthya
force-pushed
the
fix/init-container-nvidia-module-check
branch
from
ce2ef9a to
624fa74
Compare
The toolkit-validation init containers in operand DaemonSets previously polled for a toolkit-ready sentinel file on the host. It is possible for operands to (in unknown situations) to find a stale toolkit-ready file from a previous cycle, passing the init gate while nvidia-smi would actually fail. Replace the shell-based sentinel file check with a nvidia-validator check. This runs nvidia-smi through the toolkit runtime wrapper and retries until it succeeds, validating both toolkit injection and driver module readiness without depending on host sentinel files. Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>
rajathagasthya
force-pushed
the
fix/init-container-nvidia-module-check
branch
from
624fa74 to
a9c8b4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The toolkit-validation init containers in operand DaemonSets previously
polled for a toolkit-ready sentinel file on the host. During driver reinstall
cycles, it is possible for operands to (in unknown situations) to find a
stale toolkit-ready file from a previous cycle, passing the init gate
while nvidia-smi would actually fail.
Replace the shell-based sentinel file check with a nvidia-validator
check. This runs nvidia-smi through the toolkit runtime wrapper and
retries until it succeeds, validating both toolkit injection and driver
module readiness without depending on host sentinel files.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing