Skip to content

Centralise regex#18

Merged
ssjunnebo merged 10 commits intoNationalGenomicsInfrastructure:masterfrom
ssjunnebo:centralise_regex
Apr 1, 2026
Merged

Centralise regex#18
ssjunnebo merged 10 commits intoNationalGenomicsInfrastructure:masterfrom
ssjunnebo:centralise_regex

Conversation

@ssjunnebo
Copy link
Copy Markdown
Contributor

Replaces regular expression patterns in run classes with a centralised registry in StatusDB.
Requires:

  • regex_patterns document in production db
  • change the regex for NextSeq to remove the side/position (which will then get included in the flowell_id)

@ssjunnebo ssjunnebo added the no validation validation not needed label Mar 31, 2026
@ssjunnebo ssjunnebo requested review from aanil and alneberg March 31, 2026 11:20
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 51.85185% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.68%. Comparing base (56eb634) to head (ea81a1a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
dataflow_transfer/tests/test_run_classes.py 52.17% 9 Missing and 2 partials ⚠️
dataflow_transfer/utils/statusdb.py 16.66% 10 Missing ⚠️
dataflow_transfer/run_classes/generic_runs.py 68.75% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   85.97%   83.68%   -2.30%     
==========================================
  Files          10       10              
  Lines         492      527      +35     
  Branches       28       41      +13     
==========================================
+ Hits          423      441      +18     
- Misses         65       78      +13     
- Partials        4        8       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aanil
Copy link
Copy Markdown
Member

aanil commented Mar 31, 2026

change the regex for NextSeq to remove the side/position (which will then get included in the flowell_id)

Should this be changed immediately?

@ssjunnebo
Copy link
Copy Markdown
Contributor Author

change the regex for NextSeq to remove the side/position (which will then get included in the flowell_id)

Should this be changed immediately?

Ideally before deploying these changes, otherwise the flowcell ids will differ in the status database

Copy link
Copy Markdown
Member

@aanil aanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ssjunnebo ssjunnebo merged commit 47b25bb into NationalGenomicsInfrastructure:master Apr 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no validation validation not needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants