Skip to content

Make and Mise private task conventions in the tree view#14

Merged
MelbourneDeveloper merged 1 commit intoNimblesite:issue-13from
abdushakoor12:issue-13
Apr 19, 2026
Merged

Make and Mise private task conventions in the tree view#14
MelbourneDeveloper merged 1 commit intoNimblesite:issue-13from
abdushakoor12:issue-13

Conversation

@abdushakoor12
Copy link
Copy Markdown
Contributor

@abdushakoor12 abdushakoor12 commented Apr 18, 2026

TLDR;

It treats Make and Mise private tasks more like users expect. _-prefixed tasks are grouped below public tasks, separated by a divider, and visually de-emphasized. For Makefiles, help is prioritized to the top and .PHONY targets are preferred ahead of non-phony targets, while dot-prefixed special targets and % pattern rules remain hidden. Closes #13

Details

For Make and Mise:

  • _-prefixed tasks are recognized as private/internal
  • private tasks are sorted below public tasks
  • a divider is inserted between public and private groups
  • private tasks are rendered with a muted icon treatment and marked as private in the item description

For Make specifically:

  • .PHONY declarations are parsed during discovery
  • discovered Make targets now carry phony metadata
  • help is pinned to the top of the Make group
  • phony public targets sort ahead of non-phony public targets
  • dot-prefixed special targets such as .PHONY and .DEFAULT remain hidden
  • % pattern rules remain hidden
  • The result is a tree that better reflects common GNU Make and Mise conventions, reduces accidental clicks on internal tasks, and makes the primary entry points easier to scan.

How do the tests prove the change works

The E2E coverage in src/test/e2e/treeview.e2e.test.ts exercises the rendered tree, not just internal helpers.

The Private Make And Mise Tasks tests create temporary Make and Mise files and verify that:

  • public tasks appear before private _ tasks
  • a divider row appears between the groups
  • private tasks are still present after the divider
  • private tasks use the muted icon styling

The Make Target Conventions test verifies that:

  • help is first
  • phony public targets sort before non-phony public targets
  • private targets appear below the divider
  • % pattern rules are hidden
  • dot-prefixed special targets are hidden

… support for private and phony tasks, and add divider for better visual separation in tree view.
@MelbourneDeveloper MelbourneDeveloper changed the base branch from main to issue-13 April 19, 2026 10:06
@MelbourneDeveloper MelbourneDeveloper marked this pull request as ready for review April 19, 2026 10:07
@MelbourneDeveloper MelbourneDeveloper merged commit d236f57 into Nimblesite:issue-13 Apr 19, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make/Mise: Demote private (_-prefixed) targets visually and sort them below public targets

2 participants