Open
Conversation
chpy04
requested changes
Mar 24, 2026
Contributor
chpy04
left a comment
chpy04
left a comment
There was a problem hiding this comment.
Ik there is existing code that doesn't follow what im requesting but it is a good practice im trying to implement going forward
| data: { dateDeleted: new Date(), userDeletedId: deleter.userId } | ||
| }); | ||
|
|
||
| return def; |
Contributor
There was a problem hiding this comment.
Don't return because its not actually used
| * @param deleter the user requesting to delete the guestDefinition | ||
| * @param organizationId the organization ID of the deleter | ||
| */ | ||
| static async deleteGuestDefinition(deleter: User, definitionId: string, organization: Organization) { |
Contributor
There was a problem hiding this comment.
can we add a promise return type just so its clear this returns nothing?
| RecruitmentController.createGuestDefinition | ||
| ); | ||
|
|
||
| recruitmentRouter.delete('/guestDefinition/:definitionId/delete', RecruitmentController.deleteGuestDefinition); |
Contributor
There was a problem hiding this comment.
We generally want to avoid caps in route names, so lets change guestDefinition to guestdefinition. Just messaged in slack about the other ones in this file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Test Cases
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3936