Conversation
cielbellerose
left a comment
cielbellerose
left a comment
There was a problem hiding this comment.
looks so good but why light mode
| <FormHelperText error>{errors.accountCodeId?.message}</FormHelperText> | ||
| </FormControl> | ||
|
|
||
| {/* Total Shipping */} |
There was a problem hiding this comment.
yeah I imagined this down in the Purchased Items area but I agree with you - it does look better up here. maybe we could move it below description though so its a little closer to the products section? I feel like using this I would be scrolling back and forth a lot
|
|
||
| const shippingCents = baseShippingCents + (index < remainderCents ? 1 : 0); | ||
|
|
||
| updatedProducts.push({ |
There was a problem hiding this comment.
rn if we add two products to the same project it adds two shipping costs, I think Nathan wanted the cost split evenly over projects (and if it was huge difference in # of products they could fix $ manually)
| onClick={() => removeProduct(product.index)} | ||
| onClick={() => { | ||
| removeProduct(product.index); | ||
| setTimeout(() => applySplitShippingToProducts(Number(totalShipping)), 0); |
There was a problem hiding this comment.
if a value is present for Total Shipping, we can't delete any of the split shipping items (might be useful if one project doesn't need the shipping costs). I think the issue happens when a shipping product is removed here, applySplitShippingToProducts is called again which then recreates the shipping items. they could always set the value to 0 but it might be nice to fix
2 participants
Changes
Adding split shipping field to reimbursement requests. I left total cost the same it includes the shipping but I can also put like a separate shipping cost if wanted (last screenshot).
Screenshots
(updated photos)
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4027