Skip to content

#3991 moved Account Code above Refund Source #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maddynenn wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

#3991 moved Account Code above Refund Source #4097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1ccaa
#3991 moved account code to left column
Mar 26, 2026
e5b56a0
#3991 stack spacing
Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 56 additions & 56 deletions src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ const ReimbursementRequestFormView: React.FC<ReimbursementRequestFormViewProps>
<Grid container spacing={3} alignItems="flex-start">
{/* Left Column */}
<Grid item xs={12} md={6}>
<Stack spacing={3}>
<Stack spacing={4}>
{/* Vendor */}
<FormControl sx={{ borderRadius: '25px', width: '100%' }}>
<FormLabel
Expand Down Expand Up @@ -439,6 +439,60 @@ const ReimbursementRequestFormView: React.FC<ReimbursementRequestFormViewProps>
</FormControl>
)}

Copy link
Contributor

@cielbellerose cielbellerose Mar 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually quick note could we fix the stack spacing to 4 and 2 instead of 3's

{/* Account Code */}
<FormControl sx={{ borderRadius: '25px', width: '100%' }}>
<FormLabel
sx={{
color: '#dd524c',
textShadow: '1.5px 0 #dd524c',
letterSpacing: '0.5px',
textDecoration: 'underline',
textUnderlineOffset: '3.5px',
textDecorationThickness: '0.6px',
paddingBottom: '2px',
fontSize: 'x-large',
fontWeight: 'bold'
}}
>
Account Code*
</FormLabel>
<Controller
name="accountCodeId"
control={control}
render={({ field: { onChange, value } }) => {
const mappedAccountCodes = allAccountCodes
.filter((accountCode) => accountCode.allowed)
.map(accountCodesToAutocomplete);
return (
<Select
value={value}
onChange={(e) => {
onChange(e.target.value);
}}
displayEmpty
variant="outlined"
fullWidth
size="small"
IconComponent={KeyboardArrowDownIcon}
renderValue={(selected) => {
if (!selected) {
return <Typography style={{ color: 'gray' }}>Select Account Code</Typography>;
}
return mappedAccountCodes.find((accountCode) => accountCode.id === selected)?.label;
}}
>
{mappedAccountCodes.map((accountCode) => (
<MenuItem key={accountCode.id} value={accountCode.id}>
{accountCode.label}
</MenuItem>
))}
</Select>
);
}}
/>
<FormHelperText error>{errors.accountCodeId?.message}</FormHelperText>
</FormControl>

{/* Refund Sources */}
<FormControl sx={{ borderRadius: '25px', width: '100%' }}>
<FormLabel
Expand Down Expand Up @@ -627,61 +681,7 @@ const ReimbursementRequestFormView: React.FC<ReimbursementRequestFormViewProps>

{/* Right Column */}
<Grid item xs={12} md={6}>
<Stack spacing={3}>
{/* Account Code */}
<FormControl sx={{ borderRadius: '25px', width: '100%' }}>
<FormLabel
sx={{
color: '#dd524c',
textShadow: '1.5px 0 #dd524c',
letterSpacing: '0.5px',
textDecoration: 'underline',
textUnderlineOffset: '3.5px',
textDecorationThickness: '0.6px',
paddingBottom: '2px',
fontSize: 'x-large',
fontWeight: 'bold'
}}
>
Account Code*
</FormLabel>
<Controller
name="accountCodeId"
control={control}
render={({ field: { onChange, value } }) => {
const mappedAccountCodes = allAccountCodes
.filter((accountCode) => accountCode.allowed)
.map(accountCodesToAutocomplete);
return (
<Select
value={value}
onChange={(e) => {
onChange(e.target.value);
}}
displayEmpty
variant="outlined"
fullWidth
size="small"
IconComponent={KeyboardArrowDownIcon}
renderValue={(selected) => {
if (!selected) {
return <Typography style={{ color: 'gray' }}>Select Account Code</Typography>;
}
return mappedAccountCodes.find((accountCode) => accountCode.id === selected)?.label;
}}
>
{mappedAccountCodes.map((accountCode) => (
<MenuItem key={accountCode.id} value={accountCode.id}>
{accountCode.label}
</MenuItem>
))}
</Select>
);
}}
/>
<FormHelperText error>{errors.accountCodeId?.message}</FormHelperText>
</FormControl>

<Stack spacing={2}>
{/* Upload Receipts */}
<FormControl sx={{ display: 'flex', borderRadius: '25px', width: '100%' }}>
<FormLabel
Expand Down
Loading