[19.0] [MIG] document_knowledge: Migration to 19.0

[BhaveshHeliconia]

No description provided.

[stferraro]

Hi,

I reviewed the module on 19.0 and all checks are green.
Functionally and technically it looks complete from my side.

Could you please confirm if this PR is ready to be merged, or if any additional changes are required?

Thanks!

[BhaveshHeliconia]

@stferraro Thanks for reviewing the PR and leaving comments. However, comments alone don’t mark the PR as approved. To approve it, please go to the Files changed tab, click the green Review changes button, select Approve if everything looks fine, and then submit. That’s the process to approve a PR.

• From my side, no further changes are required. Once we receive approval from the maintainer, the PR can be merged.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[farhatzafar]

In document_knowledge/demo/document_knowledge.xml: groups_id should be changed to group_ids. Other than this, I have tested it on Odoo 19 and the migration looks complete.

[BhaveshHeliconia]

@farhatzafar Fixed groups_id → group_ids

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[gregory-rutecki]

Hi @CristianoMafraJunior @stferraro , I've submitted an alternative migration set for the entire knowledge module suite to 19.0 (#590, #591, #592, #593, #594, #595, #596, #597, #598, #599, #588, #589). All PRs pass pre-commit and include additional Odoo 19 fixes (privilege_id for res.groups, group_ids rename, Store API changes, html_editor migration). #590 (document_knowledge) has full green CI. I also migrated two modules that don't have PRs yet: attachment_preview (#588) and document_page_reference (#589). Would appreciate a review!

[stferraro]

@gregory-rutecki Hi
Okay, I'll do it as soon as possible. Thanks for your contribution.

[BhaveshHeliconia]

Hi @CristianoMafraJunior @stferraro , I've submitted an alternative migration set for the entire knowledge module suite to 19.0 (#590, #591, #592, #593, #594, #595, #596, #597, #598, #599, #588, #589). All PRs pass pre-commit and include additional Odoo 19 fixes (privilege_id for res.groups, group_ids rename, Store API changes, html_editor migration). #590 (document_knowledge) has full green CI. I also migrated two modules that don't have PRs yet: attachment_preview (#588) and document_page_reference (#589). Would appreciate a review!

Hi @gregory-rutecki Please make sure to check whether a PR is already open for the corresponding module version before creating a new one. The following appear to be duplicate PRs: #591, #590, #599, #598, #597, #596, #595, #594, #593, #592. Therefore, these PRs should be closed.

[gregory-rutecki]

Hi, I've submitted a complete set of 19.0 migrations for all knowledge modules (#588, #589, #590, #591, #592, #593, #594, #595, #596, #597, #598, #599), including attachment_preview and document_page_reference which don't have PRs yet. All pass pre-commit with full commit history preserved from 18.0. Found and fixed several Odoo 19 breaking changes: fields.Datetime.now(), group_ids/privilege_id renames, html_editor migration, Store API changes. Happy to collaborate on getting these merged!

[gregory-rutecki]

Tested on live Odoo 19.0 instance, LGTM. All CI green.

[pedrobaeza]

/ocabot migration document_knowledge
/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-569-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 44cb9b1. Thanks a lot for contributing to OCA. ❤️