Skip to content

Enhance role-based access control and add permission tests#3653

Open
romanett wants to merge 1 commit intomasterfrom
romanett/fixIdentityAndPermissionsCache
Open

Enhance role-based access control and add permission tests#3653
romanett wants to merge 1 commit intomasterfrom
romanett/fixIdentityAndPermissionsCache

Conversation

@romanett
Copy link
Copy Markdown
Contributor

@romanett romanett commented Apr 2, 2026

Enhance role-based access control and add permission tests

  • Improve ValidateRolePermissions logic and add ILogger support for detailed access denial logging
  • Expand default roles (add AuthenticatedUser, TrustedApplication)
  • Refine RoleBasedIdentity to merge roles and avoid duplicates
  • Set UserIdentity default GrantedRoleIds to Anonymous
  • Fix MasterNodeManager PrepareValidationCache
  • Add comprehensive unit tests for role permission validation and logging

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

- Improve ValidateRolePermissions logic and add ILogger support for detailed access denial logging
- Expand default roles (add AuthenticatedUser, TrustedApplication)
- Refine RoleBasedIdentity to merge roles and avoid duplicates
- Set UserIdentity default GrantedRoleIds to Anonymous
- Fix MasterNodeManager PrepareValidationCache
- Add comprehensive unit tests for role permission validation and logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant