Skip to content

fix: implement safe dictionary lookups in HTML template to prevent KeyError #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aarshpatel12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: implement safe dictionary lookups in HTML template to prevent KeyError #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions apps/backend/app/utils/report_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
def render_report_html(data):
params_html = "".join(f"<tr><td>{k}</td><td>{v}</td></tr>" for k, v in data["asl_parameters"])
missing_html = "".join(f"<li>{param}</li>" for param in data["missing_parameters"])
# 1. Safely handle asl_parameters (whether it's a dict or a list)
asl_params = data.get("asl_parameters", {})
if isinstance(asl_params, dict):
params_html = "".join(f"<tr><td>{k}</td><td>{v}</td></tr>" for k, v in asl_params.items())
else:
params_html = "".join(f"<tr><td>{k}</td><td>{v}</td></tr>" for k, v in asl_params)

# 2. Safely get missing parameters (checking both the new and old key names)
missing_params = data.get("missing_required_parameters", data.get("missing_parameters", []))
missing_html = "".join(f"<li>{param}</li>" for param in missing_params)

# 3. Safely get the reports with a fallback default string
basic_report = data.get("basic_report", "No basic report available.")
extended_report = data.get("extended_report", "No extended report available.")

return f"""
<html>
<head>
Expand All @@ -18,13 +31,13 @@ def render_report_html(data):
{params_html}
</table>
<h2>Basic Report</h2>
<p>{data["basic_report"]}</p>
<p>{basic_report}</p>
<h2>Extended Report</h2>
<p>{data["extended_report"]}</p>
<p>{extended_report}</p>
<h2>Missing Parameters</h2>
<ul>
{missing_html}
</ul>
</body>
</html>
"""
"""