Skip to content

fix: validate invalid dicom uploads before processing #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlwinXue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate invalid dicom uploads before processing #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions apps/backend/app/routers/reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from typing import List, Optional
from .data import data
from pyaslreport import generate_report, get_bids_metadata
from pyaslreport.main import get_dicom_header
from pyaslreport.enums import ModalityTypeValues
from fastapi.responses import FileResponse
from weasyprint import HTML
Expand Down Expand Up @@ -89,6 +90,16 @@ async def get_report_dicom(
except Exception as e:
print(f"Error reading DICOM file {file.filename}: {e}")

try:
get_dicom_header(data["dicom_dir"])
except (TypeError, ValueError, OSError, FileNotFoundError) as e:
print(f"Invalid DICOM upload: {e}")
await remove_dir(base_dir)
raise HTTPException(
status_code=status.HTTP_400_BAD_REQUEST,
detail="No valid DICOM files provided"
)

try:
metadata, asl_context = get_bids_metadata(data)
print("Generated BIDS metadata:", metadata)
Expand Down
6 changes: 3 additions & 3 deletions apps/backend/tests/test_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ def test_get_report_dicom_with_invalid_file(tmp_path):
file_path.write_text("not a dicom")
with open(file_path, "rb") as f:
response = client.post(
"/report/process/dicom",
"/api/report/process/dicom",
files={"dcm_files": ("not_a_dicom.txt", f, "text/plain")},
data={"modality": "ASL"}
)
# Should still return 500 due to invalid dicom
assert response.status_code in [500, 200]
assert response.status_code == 400
assert response.json()["detail"] == "No valid DICOM files provided"

def test_report_pdf_endpoint():
# Minimal valid report_data for rendering
Expand Down