fix: return asl context for siemens dicom metadata#59
Open
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Open
fix: return asl context for siemens dicom metadata#59AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi mentors! 👋
This PR addresses the DICOM endpoint crash reported in Issue #42.
The Problem:
The DICOM route expects
get_bids_metadata()to return a two-item tuple:(metadata, asl_context). However,SiemensBasicSinglePLD.extract_bids_metadata()returned only the metadata dictionary, which caused the endpoint to fail withValueError: not enough values to unpackwhen a Siemens ASL sequence matched.The Solution:
Contract Alignment: Updated
SiemensBasicSinglePLD.extract_bids_metadata()to return(bids, asl_context)like the GE ASL sequence implementations.Default ASL Context: Added a default single-PLD Siemens ASL context of
["deltaM", "m0scan"], which matches the existing single-PLD assumptions in the backend flow.Regression Coverage: Added a focused package test that verifies the Siemens sequence now returns both metadata and ASL context together.
Validation:
Ran
python -m pytest package/src/pyaslreport/tests/test_siemens_basic_single_pld.py -qand the new sequence contract test passed.Fixes #42