fix: return clear invalid modality and dsc placeholder responses#61
Open
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Open
fix: return clear invalid modality and dsc placeholder responses#61AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi mentors! 👋
This PR addresses the invalid modality handling and DSC placeholder behavior reported in Issue #35.
The Problem:
Invalid modality values were bubbling into the backend flow as uncaught exceptions, which produced 500 responses instead of clear client errors. Separately,
DSCProcessor.process()returned a bare string ("dsc data"), which is not a stable API shape for callers expecting structured report data.The Solution:
Clear Modality Parsing: Added a small modality parsing helper in the backend router so unsupported values now return
400 Bad Requestwith a deterministicUnsupported modality: ...message.Structured DSC Placeholder: Updated
DSCProcessorto return a dictionary placeholder withmodality,status, andmessagefields instead of a raw string.Regression Coverage: Added a backend test for invalid modality handling and a package test that locks in the DSC placeholder response format.
Validation:
Ran
python -m pytest apps/backend/tests/test_report.py -q -k "test_get_report_bids_invalid_modality"(withDYLD_FALLBACK_LIBRARY_PATH=/opt/homebrew/lib) andpython -m pytest package/src/pyaslreport/tests/test_dsc_processor.py -q; both targeted tests passed.Fixes #35