fix: normalize temp paths for cross-platform support#62
Open
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Open
fix: normalize temp paths for cross-platform support#62AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi mentors! 👋
This PR addresses the hardcoded
/tmppath issue reported in Issue #37.The Problem:
The package configuration and DICOM converter assumed Unix-style
/tmp/...paths, which breaks on Windows and makes temp file handling less portable in general.The Solution:
Runtime Path Normalization: Added a small normalization step in the config loader that rewrites legacy
/tmp/...entries to the current platform temp directory viatempfile.gettempdir().Portable Converter Default: Updated
DICOM2NiFTIConverter.convert()so its default output location is resolved at runtime from the platform temp directory instead of being hardcoded to/tmp/upload.Regression Coverage: Added targeted tests for both config path normalization and the converter default behavior.
Validation:
Ran
python -m pytest package/src/pyaslreport/tests/test_temp_path_normalization.py -qand both temp-path tests passed.Fixes #37