test: isolate package unit tests from source tree#63
Open
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Open
test: isolate package unit tests from source tree#63AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi mentors! 👋
This PR addresses the package-level test structure work described in Issue #45.
The Problem:
The package tests lived under
src/pyaslreport/tests, which mixed test code into the package source tree and made discovery/import behavior brittle. In particular, the existing test file relied on a broken relative import pattern that did not reflect a clean installable-package workflow.The Solution:
Isolated Test Layout: Moved the package tests into a dedicated
package/tests/unitdirectory.Explicit Discovery: Added
package/pytest.iniso pytest resolvessrccorrectly and only discovers the isolated unit test suite.Cleaned Source Tree: Removed the old in-package test file from
src/pyaslreport/tests.Updated Coverage Base: Recreated the
get_bids_metadata()tests in the new package test location with imports and mocks that match the actual runtime behavior.Validation:
Ran
python -m pytest -qfrom thepackage/directory and the isolated package suite passed with 4 tests.Fixes #45