perf: avoid scanning entire dicom directory for header lookup#64
Open
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Open
perf: avoid scanning entire dicom directory for header lookup#64AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
AlwinXue wants to merge 1 commit intoOSIPI:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi mentors! 👋
This PR addresses the DICOM header lookup performance issue reported in Issue #28.
The Problem:
get_dicom_header()scanned every file in the DICOM directory usingpydicom.dcmread(..., stop_before_pixels=True), collected all readable candidates, and then performed a second read on the first valid file. For routes that only need a single representative header, this creates unnecessary O(N) disk I/O.The Solution:
Early Return: Updated
get_dicom_header()to return immediately when it finds the first readable DICOM header.Single Read Path: The function now reuses that first successful read instead of reading the same file twice.
Regression Coverage: Added a focused unit test that verifies the function stops after the first valid DICOM file rather than scanning the rest of the directory.
Validation:
Ran
python -m pytest package/src/pyaslreport/tests/test_get_dicom_header.py -qand the new performance-focused regression test passed.Fixes #28