fix(#45): harden download endpoints against path traversal#46
Open
linisha15 wants to merge 1 commit intoOSeMOSYS:masterfrom
Open
fix(#45): harden download endpoints against path traversal#46linisha15 wants to merge 1 commit intoOSeMOSYS:masterfrom
linisha15 wants to merge 1 commit intoOSeMOSYS:masterfrom
Conversation
Hey @linisha15 Looks great! This correctly implements the pathlib containment check we discussed in Issue #45. Verified locally and it works.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
Summary
This PR fixes #45 by preventing path traversal in all file download routes.
Changes
Path.resolve()andPath.is_relative_to()400 Bad Requestfor invalid/traversal file paths404 Not Foundbehavior for missing filesEndpoints updated
/downloadDataFile/downloadFile/downloadCSVFile/downloadResultsFileFile changed
Security impact
../../../...Validation
400404Closes #45