Added icon and author

[Jordonbc]

No description provided.

[github-actions]

Read the modified HTML template and TypeScript file to review the PR changes.

opencode session  |  github run

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a8516d123

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

Code Review Summary

Changes Overview

This PR adds an application icon and author information to the About modal.

Files changed:

• Frontend/public/OpenVCS-128.png - New icon file
• Frontend/src/modals/about.html - Added <img> for logo and <div> for author
• Frontend/src/scripts/features/about.ts - Populates logo src, version, build, and author

Positives

• ✅ Correct use of import.meta.env.BASE_URL (line 44 in about.ts) - addresses the P2 badge comment already in the PR
• ✅ Good accessibility attributes in HTML (aria-hidden, aria-modal, aria-labelledby)
• ✅ Proper null handling with optional chaining and nullish coalescing
• ✅ Clean separation of concerns between template and script

Potential Improvements

1. Image error handling (about.html:11-16): Consider adding an onerror fallback:

   onerror="this.style.display='none'"

2. Conditional visibility (about.html:19-20): Build and author lines show empty space when data is missing. Could conditionally hide these elements when empty for cleaner UI:

   if (aboutBuild) {
       aboutBuild.textContent = info?.build ?? "";
       aboutBuild.style.display = info?.build ? "" : "none";
   }

3. Icon sizing: The 128px source image is scaled down to 40x40 in the modal. Consider adding a smaller dedicated icon (e.g., 48px) to reduce bundle size.

Verdict

LGTM - The changes are clean and functional. The P2 concern noted in the PR is already addressed by using BASE_URL. The suggested improvements are minor polish items, not blockers.

opencode session  |  github run

[github-actions]

Code Review

Verdict: ✅ LGTM - Clean implementation.

Positives

• Uses import.meta.env.BASE_URL (about.ts:57) - properly addresses the P2 badge concern from Codex
• Good image error handling with fallback (about.ts:53-55)
• setOptionalText helper prevents empty whitespace when data is missing (about.ts:12-18, 60-61)
• Clean separation between template (empty src="") and dynamic population in script
• Proper accessibility attributes in HTML

Minor suggestions (non-blocking)

1. About.ts:56 - The aboutLogo.style.display = "block" could be removed since the HTML already has display:block inline, but it's harmless.

2. About.ts:63-66 - The disabled state logic is correct, but the href="#" fallback could cause confusion if clicked. Consider:

   aboutHome.href = info?.homepage || "";
   aboutHome.style.visibility = info?.homepage ? "visible" : "hidden";

   (same for repo/licenses)

Summary

No blocking issues. The PR correctly adds the application icon and author information to the About modal with proper path handling for both dev and production builds.

opencode session  |  github run

[github-actions]

Code Review

Verdict: ✅ LGTM

The PR correctly adds the application icon and author information to the About modal. The P2 badge concern from Codex is already addressed using import.meta.env.BASE_URL.

Positives

• ✅ Uses import.meta.env.BASE_URL (about.ts:65) - properly resolves the P2 concern
• ✅ Good image error handling with onerror fallback (about.ts:62-64)
• ✅ setOptionalText helper prevents empty whitespace when data is missing
• ✅ Proper accessibility attributes in HTML
• ✅ Clean separation between template and script

Minor Issues (non-blocking)

1. about.ts:62-64 - The onerror handler is reassigned each time openAbout() is called. This works but is slightly inefficient. Consider moving it outside the function or only setting it once.

2. about.ts:75-77 - License URL assumes GitHub format:

   const licenseUrl = repo ? `${repo}/blob/HEAD/LICENSE` : "";

   This will break for GitLab, Bitbucket, or self-hosted repos. Consider either:

   • Documenting the GitHub assumption
   • Adding a license_url field from the backend

3. about.ts:65 - Uses 40px icon. The PR also added 128px icon but only uses the smaller one (good for bundle size).

Summary

No blocking issues. Clean implementation that properly handles both dev and production paths.

opencode session  |  github run