Skip to content

Merge pull request #201 from Open-VCS/Dev Merge pull request #200 from Open-VCS/Add-Beta Implement beta testing#203

Merged
Jordonbc merged 1 commit intoDevfrom
Beta
Mar 24, 2026
Merged

Merge pull request #201 from Open-VCS/Dev Merge pull request #200 from Open-VCS/Add-Beta Implement beta testing#203
Jordonbc merged 1 commit intoDevfrom
Beta

Conversation

@Jordonbc
Copy link
Copy Markdown
Collaborator

No description provided.

Merge pull request #200 from Open-VCS/Add-Beta

Implement beta testing
@github-actions
Copy link
Copy Markdown

Code Review: Beta Testing Implementation (PR #201)

Summary

Good implementation overall. Adds proper beta channel support with a new CI workflow and moves update checking to the Rust backend.

Issues to Address

1. Unused imports (Backend/src/tauri_commands/updater.rs:3)
info and trace are imported but never used.

2. Missing macOS in beta workflow (.github/workflows/beta.yml)
The matrix only builds Ubuntu and Windows. Compare with the stable release workflow to ensure consistency if macOS builds are desired.

3. Race condition risk (beta.yml)
The workflow deletes and recreates openvcs-beta tag without locking. Concurrent pushes could cause issues.

4. Hardcoded fork path in stable URL (Backend/build.rs:138)
The default repo still points to Jordonbc/OpenVCS instead of Open-VCS/OpenVCS. Forks using OPENVCS_REPO will work, but the default should probably be the main repo.

Minor Suggestions

  • Add comments explaining the version string format (pkg_version-channel+git.branch.hash[.dirty])
  • Consider adding prerelease: true to version suffix logic for beta/nightly

What Looks Good

  • Clean separation of concerns: Rust handles update checks, frontend just displays results
  • Beta channel falls back to stable correctly
  • OPENVCS_REPO env var allows fork customization
  • Proper cargo:rerun-if-env-changed directives
  • Removing direct GitHub API calls from frontend is more maintainable

Tests

Did you run just test or at least cargo test --workspace and npm --prefix Frontend test?

New%20session%20-%202026-03-24T04%3A20%3A25.135Z
opencode session  |  github run

@Jordonbc Jordonbc merged commit 2827003 into Dev Mar 24, 2026
6 checks passed
Jordonbc added a commit that referenced this pull request Mar 24, 2026
Merge pull request #203 from Open-VCS/Beta

Merge pull request #201 from Open-VCS/Dev

Merge pull request #200 from Open-VCS/Add-Beta

Implement beta testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant