Wrap GCMC push/pop pairs in try/finally to guard against crashes#131
Merged
Wrap GCMC push/pop pairs in try/finally to guard against crashes#131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to openbiosim/loch/#15:
When a GCMC simulation crashes mid-move, the paired pop() call after gcmc_sampler.push() is never reached, leaving the CUDA context stack unbalanced. All push/pop pairs around GCMC operations in both the repex and base runners are now wrapped in try/finally to guarantee the context is always popped, even when an exception propagates. This also adds the missing push/pop pairs to the base runner, which had GCMC move calls but no context management at all.