Skip to content

CLI: Rollback some versions for node 18 compatibility#1325

Merged
josephjclark merged 8 commits intomainfrom
node18
Mar 23, 2026
Merged

CLI: Rollback some versions for node 18 compatibility#1325
josephjclark merged 8 commits intomainfrom
node18

Conversation

@josephjclark
Copy link
Collaborator

Rolling back a couple of versions for node 18 compatibility.

This is needed for github sync, which uses node 18 in the actions. We need to do something about that.

I've also restored the node 18 integration tests, as we clearly need them still

Fixes #1324 (sort of)

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@github-project-automation github-project-automation bot moved this to New Issues in Core Mar 20, 2026
@josephjclark
Copy link
Collaborator Author

All tests here break in node 18, both locally and in CI.

Same on main.

Not going to worry about this if it's not free because we shouldn't be in this state for very long.

I have run a node18 pull with openfnx and it worked fine - that'll have to be good enough

@josephjclark

This comment was marked as outdated.

@josephjclark josephjclark merged commit a9d6c29 into main Mar 23, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from New Issues to Done in Core Mar 23, 2026
@josephjclark josephjclark deleted the node18 branch March 23, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

CLI on main is incomptible with github sync

2 participants