Add WebAssembly SIMD SGEMM and DGEMM kernels#5680
Open
teddygood wants to merge 1 commit intoOpenMathLib:developfrom
Open
Add WebAssembly SIMD SGEMM and DGEMM kernels#5680teddygood wants to merge 1 commit intoOpenMathLib:developfrom
teddygood wants to merge 1 commit intoOpenMathLib:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5676 and #4023
This PR adds a WebAssembly SIMD GEMM kernel for
WASM128_GENERICand wires it up forSGEMM/DGEMMonly. The generic packing paths are unchanged.The kernel keeps the existing generic
2x2GEMM structure and replaces the hot inner loop withwasm_simd128.hintrinsics.In a Pyodide/Emscripten validation setup,
sgemm/dgemmcorrectness passed, and the kernel outperformed the current generic-msimd128baseline by about4.1x-4.5xforsgemmand2.2x-2.4xfordgemm.