Filter simulation CSV to comparison signals only#31
Merged
AnHeuermann merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
Pass the list of signals to be compared (from comparisonSignals.txt or the reference CSV columns) to run_simulate before solving, so that only the relevant observed variables are written to disk. This avoids serialising thousands of algebraic variables when only a handful are actually verified. compare_with_reference gains a signals keyword that accepts the pre-resolved list, skipping the redundant file/CSV read it would otherwise perform itself. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Some models like
Modelica.Electrical.Analog.Examples.Lines.LightningSegmentedTransmissionLinehave huge results and need forever to save the CSV file.Changes
Pass the list of signals to be compared (from comparisonSignals.txt or the reference CSV columns) to run_simulate before solving, so that only the relevant observed variables are written to disk. This avoids serialising thousands of algebraic variables when only a handful are actually verified.
compare_with_reference gains a signals keyword that accepts the pre-resolved list, skipping the redundant file/CSV read it would otherwise perform itself.