Skip to content

Fix simulation of stateless models by supplying explicit saveat #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnHeuermann merged 1 commit into from
Mar 19, 2026
Merged

Fix simulation of stateless models by supplying explicit saveat #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/simulate.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ function run_simulate(ode_prob, model_dir::String,
# to the log file so they don't clutter stdout.
sol = Logging.with_logger(logger) do
# Overwrite saveat, always use dense output.
solve(ode_prob, Rodas5P(); saveat = Float64[], dense = true)
# For stateless models (no unknowns) the adaptive solver takes no
# internal steps and sol.t would be empty with saveat=[].
# Supply explicit time points so observed variables can be evaluated.
sys = ode_prob.f.sys
saveat = isempty(ModelingToolkit.unknowns(sys)) ?
collect(range(ode_prob.tspan[1], ode_prob.tspan[end]; length = 500)) :
Float64[]
solve(ode_prob, Rodas5P(); saveat = saveat, dense = true)
end
sim_time = time() - t0
if sol.retcode == ReturnCode.Success
Expand Down
Loading