-
Notifications
You must be signed in to change notification settings - Fork 1
feat(spp_programs): show cycle compliance status on registrant form #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e729c6c
feat(spp_programs): show cycle compliance status on registrant form
emjay0921 6fc933f
test(spp_programs): add tests for cycle compliance on registrant form
emjay0921 c07774c
fix(spp_programs): change non_compliant color from yellow to red in c…
emjay0921 710c608
fix(spp_programs): split cycles smart button into two separate buttons
emjay0921 ac74d23
fix(spp_programs): improve cycle membership list columns
emjay0921 c2216c3
fix(spp_programs): add related program_id field to cycle membership
emjay0921 d7e27fc
fix(spp_programs): Non-Compliant button opens only non-compliant cycles
emjay0921 005390d
fix(spp_programs): hide New button on non-compliant cycles view
emjay0921 5d9edc4
fix(spp_programs): hide New button on cycle memberships view
emjay0921 82c6329
Merge remote-tracking branch 'origin/19.0' into feat/cycle-compliance…
emjay0921 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation of
_compute_latest_cycle_stateperforms asearch()inside a loop, which leads to an N+1 query pattern. This will significantly degrade performance when viewing a list of program memberships (e.g., on the registrant form). It is highly recommended to use_read_groupto fetch the latest cycle membership IDs for all records in the batch in a single query.