Skip to content

feat(spp_api_v2): auto-assign system_id to registrants for API addressability #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pmigueld wants to merge 15 commits into
base: 19.0
Choose a base branch
from

refactor(spp_api_v2): hide system_id from UI instead of readonly prot…

385a127
Select commit
Loading
Failed to load commit list.
Draft

feat(spp_api_v2): auto-assign system_id to registrants for API addressability #162

refactor(spp_api_v2): hide system_id from UI instead of readonly prot…
385a127
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 17, 2026 in 0s

71.63% (+0.26%) compared to 1f4203c

View this Pull Request on Codecov

71.63% (+0.26%) compared to 1f4203c

Details

Codecov Report

❌ Patch coverage is 81.90476% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.63%. Comparing base (1f4203c) to head (385a127).
⚠️ Report is 4 commits behind head on 19.0.

Files with missing lines Patch % Lines
spp_api_v2/__init__.py 73.68% 5 Missing ⚠️
spp_api_v2/models/res_partner_system_id.py 82.75% 5 Missing ⚠️
spp_api_v2/services/membership_utils.py 63.63% 4 Missing ⚠️
spp_api_v2/models/spp_registry_id_system.py 57.14% 3 Missing ⚠️
spp_api_v2/routers/program_membership.py 50.00% 1 Missing ⚠️
..._change_request/services/change_request_service.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0     #162      +/-   ##
==========================================
+ Coverage   71.36%   71.63%   +0.26%     
==========================================
  Files         932      935       +3     
  Lines       54792    55413     +621     
==========================================
+ Hits        39101    39693     +592     
- Misses      15691    15720      +29
Files with missing lines Coverage Δ
spp_api_v2/__manifest__.py 0.00% <ø> (ø)
spp_api_v2/models/__init__.py 100.00% <100.00%> (ø)
spp_api_v2/routers/bulk.py 100.00% <ø> (ø)
spp_api_v2/routers/filter.py 29.91% <ø> (ø)
spp_api_v2/routers/group.py 74.36% <100.00%> (+0.42%) ⬆️
spp_api_v2/routers/individual.py 77.54% <100.00%> (+0.24%) ⬆️
spp_api_v2/services/group_service.py 85.04% <100.00%> (+0.26%) ⬆️
spp_api_v2/services/individual_service.py 72.46% <100.00%> (+0.71%) ⬆️
spp_api_v2/services/program_membership_service.py 93.37% <100.00%> (+1.37%) ⬆️
spp_api_v2/routers/program_membership.py 74.30% <50.00%> (+1.06%) ⬆️
... and 5 more

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov