Skip to content

[SECURITY] Harden GitHub Workflows#512

Merged
John McCall (lowlydba) merged 1 commit intomainfrom
306-devops-create-omf-ruleset-for-all-public-repos
Apr 9, 2026
Merged

[SECURITY] Harden GitHub Workflows#512
John McCall (lowlydba) merged 1 commit intomainfrom
306-devops-create-omf-ruleset-for-all-public-repos

Conversation

@lowlydba
Copy link
Copy Markdown
Contributor

Clears zizmor flagged security issues. After this PR, we'll use OMF Security Checks to enforce these settings going forward.

Add a 7-day default cooldown to Dependabot to reduce frequent dependency PRs. Update GitHub Actions workflow for building/deploying manifests: move repo permissions into the deploy job, set explicit job-level permissions (pages, id-token, contents), give the job a name, disable persist-credentials for checkout, and pin several Actions to specific versions/commits (checkout, setup-python, configure-pages, upload-pages-artifact, deploy-pages) for reproducible and secure deployments to GitHub Pages.

Signed-off-by: John McCall <john@overturemaps.org>
Copilot AI review requested due to automatic review settings April 8, 2026 15:26
@lowlydba John McCall (lowlydba) requested a review from a team as a code owner April 8, 2026 15:26
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the repo’s GitHub automation configuration to address zizmor security findings and prepare for enforcement via OMF Security Checks.

Changes:

  • Pins GitHub Actions used in the Pages workflow to full commit SHAs and disables persisted checkout credentials.
  • Tightens GITHUB_TOKEN permissions by defaulting to contents: read at workflow scope and granting elevated permissions only on the deploy job.
  • Adds a Dependabot cooldown window to reduce update churn.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/build-manifests.yml Pins actions to SHAs, scopes permissions to the deploy job, and disables persisted credentials for checkout.
.github/dependabot.yml Adds a cooldown period for Dependabot updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lowlydba John McCall (lowlydba) merged commit 1a96bce into main Apr 9, 2026
11 checks passed
@lowlydba John McCall (lowlydba) deleted the 306-devops-create-omf-ruleset-for-all-public-repos branch April 9, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants