fix(cli): pass pluginInstances to getPluginConfig to support non-array plugins#1384
Merged
fix(cli): pass pluginInstances to getPluginConfig to support non-array plugins#1384
Conversation
…y plugins (#1246) Passing the raw `plugins` array to `getPluginConfig` caused a TypeError when `plugins` contained non-array entries (e.g. function plugins), as `data[1]` would be undefined. Since `pluginInstances` is already filtered to only `docusaurus-plugin-openapi-docs` tuples, passing it instead is both correct and safe. Also prevents incorrect matches when another plugin shares the same ID as the openapi-docs plugin. Fixes #1246 Closes #1263 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Size Change: 0 B Total Size: 2.26 MB ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 64e7653): https://docusaurus-openapi-36b86--pr1384-qenbr4eq.web.app (expires Thu, 09 Apr 2026 18:16:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeErrorwhenpluginsindocusaurus.config.tscontains non-array entries (e.g. function plugins).getPluginConfigwas iterating the rawpluginsarray and accessingdata[1].id, which throws whendatais a function.pluginInstancesis already filtered to onlydocusaurus-plugin-openapi-docstuples at each call site, passing it instead of the rawpluginsarray is both correct and safe.Fixes #1246
Closes #1263
Test plan
gen-api-docs,clean-api-docs,gen-api-docs:version, andclean-api-docs:versioncommands work correctly whendocusaurus.config.tscontains a function plugin alongside the openapi-docs plugin🤖 Generated with Claude Code