Further cleaning the handling of grid searching errors#2177
Merged
fluidnumerics-joe merged 20 commits intov4-devfrom Sep 13, 2025
Merged
Further cleaning the handling of grid searching errors#2177fluidnumerics-joe merged 20 commits intov4-devfrom
fluidnumerics-joe merged 20 commits intov4-devfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #2175 by exploring whether it is possible to remove the while-loop in the
_search_indices_curvilinear_2dfunction.Currently, there are three breaking unit tests:
Note that in the first breaking unit test, a -3 means
GRID_SEARCH_ERROR, so this is a clear case where the first computation ofxsiandetafailed to produce results within the [0, 1] rangemainfor v3 changes,v4-devfor v4 changes)