Fix sort order after column reorder on page reload#1346
Open
wschopohl wants to merge 1 commit intoPart-DB:masterfrom
Open
Fix sort order after column reorder on page reload#1346wschopohl wants to merge 1 commit intoPart-DB:masterfrom
wschopohl wants to merge 1 commit intoPart-DB:masterfrom
Conversation
When columns are reordered via colReorder and the page is reloaded, the saved sort state uses visual column indices. These were sent directly as initial_order to the server, which interprets them as original indices — causing the wrong column to be sorted. Use the saved colReorder mapping to translate visual indices back to original indices before sending initial_order in the _init request.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
============================================
- Coverage 57.22% 57.20% -0.03%
Complexity 8410 8410
============================================
Files 616 616
Lines 27117 27117
============================================
- Hits 15518 15512 -6
- Misses 11599 11605 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initial_orderwas sending them to the server as-is — the server interpreted them as original indices, sorting the wrong columncolReordermapping to translate visual indices back to original indices before sendinginitial_orderin the_initrequestSteps to reproduce